test: replace internals with public API#25309
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove instances where
--expose-internalsis used to gain access tobuffer.kStringMaxLength. The property is availalble without a flag. It
is undocumented but the same as the documented
buffer.constants.MAX_STRING_LENGTHso use that. (We even have a testthat confirms that they are the same value.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes